Build list of the right length in #finalizeSampling #124762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>non-issue
:Analytics/Aggregations
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
craigtaverner
approved these changes
Mar 13, 2025
Contributor
craigtaverner
left a comment
craigtaverner
left a comment
There was a problem hiding this comment.
LGTM.
Amusingly, the move from functional style, to classic java for loops, did not really increase the number of lines of code.
Contributor
|
Perhaps we should add the |
Contributor
|
@iverase out of curiosity, what scenarios lead to a list with unnecessary big capacity? |
Contributor
Author
|
@idegtiarenko the method #toList initialise the arrays the standard way (new ArrayList()) so you end up with empty slots: 
|
iverase
added
the
auto-backport
This was referenced Mar 13, 2025
Collaborator
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Mar 13, 2025
Avoid oversize list in internal aggregations.
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Mar 13, 2025
Avoid oversize list in internal aggregations.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 13, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using the java command
buckets.stream().map(...).toList()to build internal aggregation with sampling. While this is correct it has a side effect, the final list is normally oversize. In this case we know the length of the final list, therefore let's create list of the right size as we can have thousand of those objects on heap.